Conversation
|
@bobpaw are you still reviewing? |
Yes, sorry. I have a few more longer files to look at. I had also submitted a patch to Angel via email which adjusts his isCapstone function slightly. I'll finish up the review today. |
bobpaw
left a comment
There was a problem hiding this comment.
Sorry for lots of comments. After this PR is merged I will be working on adding Doxygen documentation for new and improved features.
bobpaw
left a comment
There was a problem hiding this comment.
Looks good to me. Might be worth configuring with VALGRIND=valgrind and running ctests (probably excluding the long capstone tests -E '^capVol.*').
|
@Angelyr The changes look good. Thank you. Once we have checked with valgrind/asan I think this will be ready to merge. |
|
/runtests |
|
Build Log |
|
Sounds good to me. |
|
@cwsmith Yes looks good to me |
Changes to coarsen
Changes to snapping
More testing
Most of the these changes to snapping and coarsen came from Li's thesis with some minor exceptions: